[MPlayer-dev-eng] [PATCH] Fix vd_ffmpeg.c::get_format() to actually query format

Gwenole Beauchesne gbeauchesne at splitted-desktop.com
Thu Feb 19 13:56:54 CET 2009


On Thu, 19 Feb 2009, Reimar Döffinger wrote:

>> - Besides, there are cases where init_vo() (and more precisely,
>> mpcodecs_config_vo()) is no-op because sh->disp_w and sh->disp_h are both 0
>> so we turned out to not actually test VO capabilities. IOW, get_format()
>> can be called as early as neither width nor height are parsed yet.
>
> I am quite sure this is wrong. In order to test a pix_fmt you need to
> completely destroy the filter chain and rebuilt it with conversion
> filters inserted where-ever necessary, I can't see your query_format do
> that?

OK, a workaround, unless someone knows how to fix h264.c, is to make the 
query_format() local to vd_ffmpeg.c and implement it as an init_vo() with 
avctx->{width,height} set to some defaults if zero (e.g. 64x64), 
temporarily. Then, once we know the actual size, VO is reconfigured 
anyway.


More information about the MPlayer-dev-eng mailing list