[MPlayer-dev-eng] [PATCH] ao_dart

[Diego Biurrun]

On Mon, Feb 16, 2009 at 12:53:55AM +0900, KO Myung-Hun wrote:
> 
> This patch add a ao_dart for OS/2 DART audio system.
> 
> --- libao2/ao_dart.c    (revision 0)
> +++ libao2/ao_dart.c    (revision 0)
> @@ -0,0 +1,266 @@
> +/*
> + * libao2 DART Audio Output Driver for MPlayer

DART audio output driver

Maybe say something about OS/2.

> +#define OUTBURST_SAMPLES    512
> +#define DART_SAMPLES        ( OUTBURST_SAMPLES << 2 )

I don't really like the way you add spaces inside parentheses.

> +static int get_space( void )
> +{
> +    return ( m_nBufSize - m_nBufLen );

useless parentheses

This is missing a man page update, changelog update would also be nice.

Diego