[MPlayer-dev-eng] [PATCH] '-priority' support on OS/2

[Aurelien Jacobs]

KO Myung-Hun wrote:

> >> --- configure	(revision 28494)
> >> +++ configure   (working copy)
> >> @@ -718,9 +722,11 @@
> >>  def_pthread_cache="#undef PTHREAD_CACHE"
> >> +def_priority="#undef CONFIG_PRIORITY"
> >>     
> >
> > Set this to 0 here, then..
> >
> >   
> >> --- mplayer.c	(revision 28494)
> >> +++ mplayer.c   (working copy)
> >> @@ -2594,17 +2596,12 @@
> >> +
> >> +#ifdef CONFIG_PRIORITY
> >> +    set_priority();
> >> +#endif
> >>     
> >
> > .. you can use the following here:
> >
> >   if (CONFIG_PRIORITY)
> >       set_priority();
> >
> >   
> 
> What's the benefit from this ?

One line less. More readable... Should be obvious...

> And this require to compile 'osdep/priority.c' unconditionally.

No it don't ! The compiler optimize out the if(0).

Aurel