[MPlayer-dev-eng] [PATCH] Fix fontconfig crash when it can't find a config directory

Uoti Urpala uoti.urpala at pp1.inet.fi
Thu Dec 17 00:38:54 CET 2009


On Wed, 2009-12-16 at 23:43 +0100, Adrian Stutz wrote:
> On Wed, Dec 16, 2009 at 10:38 PM, Uoti Urpala <uoti.urpala at pp1.inet.fi>wrote:
> > You also left invalid indentation in the file, you should fix that.

> The file didn't look correctly indented but now I realize the tabs are
> supposed to be 8 spaces wide while soft-tabs are 4 spaces wide (with some
> lines being indeted 1.5 tabs: one 8-space tab plus one 4-space soft-tab).

Tab characters are always 8 spaces, and can be used to represent a
string of 8 spaces regardless of how many indentation levels that is.
The style used is 4 spaces per indentation level. So a tab + 4 spaces is
a valid way to represent an indent of 12 spaces or 3 indentation levels.
I don't consider that to be broken, nor is it particularly rare - it's
been the default indentation style in Emacs for a long time for example.

A couple of lines in the file contain tab characters _after_ space
characters; that I do consider somewhat broken.

> How do I ident validly in this case? Follow the inane style of the file,
> ident the current function with 4-space soft-tabs or fix the whole file?

Indent the changed lines using spaces only.




More information about the MPlayer-dev-eng mailing list