[MPlayer-dev-eng] [PATCH] use standard aspect functions for vo_quartz

Diego Biurrun diego at biurrun.de
Fri Aug 28 18:44:03 CEST 2009


On Fri, Aug 28, 2009 at 01:41:55PM +0200, Reimar Döffinger wrote:
> On Fri, Aug 28, 2009 at 11:38:08AM +0200, Guillaume POIRIER wrote:
> > On Fri, Aug 28, 2009 at 10:55 AM, Reimar
> > Döffinger<Reimar.Doeffinger at gmx.de> wrote:
> > > Btw. will the Carbon headers still be usable? Because Apple still hasn't
> > > managed to include a handful of defines for the keycodes in Cocoa, so
> > > the only place to get them from is a Carbon header.
> > > Or do we have to define them all by ourselves (duplicating that code
> > > between vo_quartz and vo_corevideo IMO is not acceptable, as well as the
> > > current mess with using "magic" numbers in corevideo that just fell out
> > > from somewhere).
> > 
> > I must admit I don't know, but at least on Leopard, they are still
> > available. Do you mean that I should switch to Snow Leopard to find
> > out?
> 
> Not seriously, we would find out anyway. I'd certainly like to clean up
> corevideo but it's a bit of a pain since I can't test it...

I don't think finding testers would be a problem.  Guillaume can test, I
can test, others can test..

Diego



More information about the MPlayer-dev-eng mailing list