[MPlayer-dev-eng] [PATCH] Fix incorrect channel ordering for various codecs

Jason Tackaberry tack at urandom.ca
Tue Aug 18 17:48:11 CEST 2009


On Tue, 2009-08-18 at 17:26 +0200, Reimar Döffinger wrote:
> > -#define AF_CHANNEL_LAYOUT_6_1_A ((117<<8)|7|AF_LFE)    // L R C LFE Ls Rs Cs
> > -#define AF_CHANNEL_LAYOUT_7_1_A ((118<<8)|8|AF_LFE)   // L R C LFE Ls Rs Rls Rrs
> > +#define AF_CHANNEL_LAYOUT_5_1_F ((117<<8)|6|AF_LFE)    // C L R LFE Ls Rs
> > +#define AF_CHANNEL_LAYOUT_6_1_A ((118<<8)|7|AF_LFE)    // L R C LFE Ls Rs Cs
> > +#define AF_CHANNEL_LAYOUT_7_1_A ((119<<8)|8|AF_LFE)   // L R C LFE Ls Rs Rls Rrs
> 
> While you're at it align the comment.

It's not aligned in the original because (I assume) it pushes the line
beyond 79 cols.  I'm not sure which is the lesser of two evils, but I
just went with the original thinking.  

Fixed.


> Cosmetics like changing the indentation should be applied in a second
> commit.

Fixed.

I'll run through all the test cases again, just to be sure, and will
commit tonight unless told otherwise.

Thanks,
Jason.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: channel-layout-fixes.patch
Type: text/x-patch
Size: 8909 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090818/a5b9c388/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: channel-layout-fixes-cosmetics.patch
Type: text/x-patch
Size: 737 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090818/a5b9c388/attachment-0001.bin>


More information about the MPlayer-dev-eng mailing list