[MPlayer-dev-eng] [PATCH] VF Overlay

[Jason Tackaberry]

Hi Ben,

On Thu, 2009-08-06 at 22:01 +0200, Benjamin Zores wrote:
> Attached is latest version of the patch.

Ah, I'm glad to see you're running with this patch now. :)  In spite of
its faults the general functionality was useful to a lot of people
(based on the private email I received).


> + * This function composites the overlay over the video mpi in the slice
> + * region specified in a slave command. (If no slice region has been
> + * explicitly set, it defaults to the whole overlay image.) If the global

Looks like I missed this one.  The parenthetical doesn't apply now that
auto slicing is enabled by default.


> + * This function is called when a new video frame is to be drawn or when the
> + * overlay needs updating. If the lockbyte of the overlay shared memory
> + * buffer is set to BUFFER_LOCKED, it means the controlling application has

With the periodic update stuff removed, I don't think "or when the
overlay needs updating" applies anymore.


> +    /* If the controlling application has locked the buffer and issued a
> +     * slave command (which causes dirty to be 1) and it's time to update
> +     * (i.e. more than 1/30th of a second has elapsed), then we process the

Ditto with the "more than 1/30th of a second" bit.


> --- DOCS/man/en/mplayer.1	(revision 29478)
> +++ DOCS/man/en/mplayer.1	(working copy)
[...]
> +The filter is controlled by the overlay slave command, and it may be used
> +even when the video is paused.

I don't think this is true anymore either.  Prefixing overlay commands
with "pausing_keep" will work but it will step frames.  Or does it work
properly with pausing_keep_force?  If it does, it might be worth
mentioning in slave.txt?

Cheers,
Jason.