[MPlayer-dev-eng] [PATCH]Reduce version.h dependencies

Carl Eugen Hoyos cehoyos at ag.or.at
Sat Apr 4 18:52:26 CEST 2009


Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:

> > I'm still fighting rebuild duration (and I wonder which measure against 
> > spurious rebuilds ever worked: It is broken since at least several 
> > hundred revisions).
> 
> Yeah, really annoying with one of those insanely slow netbook SSDs...
> 
> > Attached patch is not sufficient, but moves us in the right direction, 
> > imo.
> 
> Unless the reason is known and we know for sure this is the best way I
> am quite against changing code to fix build system issues.

In case this is a question (sorry, I tend to always believe everybody else surly
knows the problems and reasons for a long time before I do):
There are two unrelated problems, first is that version.sh is completely broken
for a long time and touches version.h after every svn up (no matter if something
was updated or not). Patch pending.
The second, probably more difficult problem is that every touch of version.h not
only forces a rebuild of mpcommon.o, but compiles (nearly?) everything. The
simple solution would be to teach Makefile exactly the dependencies version.h is
needed for (the files in this patch plus muxer_avi.c and something like
win32/gui.c)). I thought it would make more sense to reduce this number using a
global variable VERSION and then change Makefile to know mpcommon.o depends on
version.h.

Please advice, Carl Eugen




More information about the MPlayer-dev-eng mailing list