[MPlayer-dev-eng] [PATCH] x11_common: use already retrieved atoms

[Ivan Kalvachev]

On 9/19/08, Julien Danjou <julien at danjou.info> wrote:
> Signed-off-by: Julien Danjou <julien at danjou.info>
> ---
>  libvo/x11_common.c |    7 ++-----
>  1 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/libvo/x11_common.c b/libvo/x11_common.c
> index 65b88cb..4dac528 100644
> --- a/libvo/x11_common.c
> +++ b/libvo/x11_common.c
> @@ -140,14 +140,11 @@ void vo_x11_ewmh_fullscreen(int action)
>          xev.xclient.type = ClientMessage;
>          xev.xclient.serial = 0;
>          xev.xclient.send_event = True;
> -        xev.xclient.message_type = XInternAtom(mDisplay,
> -                                               "_NET_WM_STATE", False);
> +        xev.xclient.message_type = XA_NET_WM_STATE;
>          xev.xclient.window = vo_window;
>          xev.xclient.format = 32;
>          xev.xclient.data.l[0] = action;
> -        xev.xclient.data.l[1] = XInternAtom(mDisplay,
> -                                            "_NET_WM_STATE_FULLSCREEN",
> -                                            False);
> +        xev.xclient.data.l[1] = XA_NET_WM_STATE_FULLSCREEN;
>          xev.xclient.data.l[2] = 0;
>          xev.xclient.data.l[3] = 0;
>          xev.xclient.data.l[4] = 0;
> --

Patch looks OK.
Please follow the
http://svn.mplayerhq.hu/mplayer/trunk/DOCS/tech/patches.txt?view=markup
In short, attach the patch, don't inline it.

And, please write something meaningful in the message body,
even if you have to repeat the subjects.