[MPlayer-dev-eng] [PATCH] Re : Re : Direct3D vo performance increase

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Nov 23 19:15:04 CET 2008


On Sun, Nov 23, 2008 at 07:48:28PM +0200, Georgi Petrov wrote:
> I didn't understand :( Why does it have to be so hard :(
> What's the point of applying 2 and 3 (perf patch + scene begin/end),
> and creating a diff from them both? This will produce perf + begin/end
> movement patch :(

No. You do an svn update to the code that contains the code moving the
Begin/EndScene, svn diff will then compare that one to the code
containing both, the diff being only the "perf" one (though actually
both should increase performance).

> From now on I'll just submit one "feature" at a time to avoid such
> difficulties. I have the feeling that in the last 2-3 days we're
> writing more about how to submit a patch than actually working on the
> code :(

Without a very, very extensive regression test suite that really is the
only way to have at least mostly "stable" and reliable code IMO.
Anyway, I will try to take care of that part.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list