[MPlayer-dev-eng] PATCH - PNG transparency in vo_png.c

it at tidetamerboatlifts.com it at tidetamerboatlifts.com
Sat Nov 15 02:34:51 CET 2008


Thanks,
I will try the new patch.  I was sure that my patch was not correct but I
wasn't sure exactly where to correct it.  I appreciate you taking the time
to work on it and send it back.  I'll let you know how my testing goes.

-Joseph

> On Thu, Nov 13, 2008 at 08:08:30PM +0100, Reimar Döffinger wrote:
>> On Thu, Nov 13, 2008 at 11:47:46AM -0500, it at tidetamerboatlifts.com
>> wrote:
>> > @@ -193,6 +193,7 @@
>> >      switch(format){
>> >      case IMGFMT_RGB|24:
>> >      case IMGFMT_BGR|24:
>> > +    case IMGFMT_RGBA|32:
>> >          return
>> VFCAP_CSP_SUPPORTED|VFCAP_CSP_SUPPORTED_BY_HW|VFCAP_ACCEPT_STRIDE;
>>
>> And this should be just IMGFMT_RGBA (without |32). Ideally someone
>> should check on little- and big-endian that is is the right one and not
>> e.g. IMGFMT_RGB32.
>
> Testing is still very welcome, but please try the attached patch
> instead.
> Most people probably will not want that useless alpha-channel (for most
> sources it is useless) in their png files, so this is optional, you will
> have to use -vo png:alpha
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng




More information about the MPlayer-dev-eng mailing list