[MPlayer-dev-eng] [PATCH] Direct3D libvo driver

[Diego Biurrun]

On Thu, Nov 13, 2008 at 12:25:26AM +0200, Georgi Petrov wrote:
> This is my MPlayer Direct3D libvo driver. This is *VERY* preliminary
> release - just enough to be reviewed and commented for further
> corrections. Please, understand - this is the first patch in my life,
> so I could have done something wrong.

At least 50% of your patch is cosmetics.  Fix those, resend.

> --- libvo/vo_direct3d.c	(revision 0)
> +++ libvo/vo_direct3d.c	(revision 0)
> @@ -0,0 +1,951 @@
> +/** @brief Destroy D3D Context related to the current window
> + *  @author Georgi Petrov, gogothebee at gmail.com
> + *  @date 31.10.2008
> + *  @return TRUE on success, FALSE on failure
> + */
> +void D3DDestroyContext ()
> +
> +/** @brief (Re)Create MPlayer Window on the screen
> + *  @author Georgi Petrov, gogothebee at gmail.com
> + *  @date 31.10.2008
> + *  @return TRUE on success, FALSE on failure
> + */
> +int CreateWindowOnScreen ()
> +
> +/** @brief (Re)Initialize Direct3D. Kill and recreate context.
> + *  @author Georgi Petrov, gogothebee at gmail.com
> + *  @date   31.10.2008
> + *  @param  NewWindow The new Window's coordinates used to
> + *                    create D3D context
> + *  @return TRUE on success, FALSE on failure
> + */
> +int D3DRecreateContext()
> +
> +/** @brief Switch between Fullscreen and windowed mode
> + *  @author Georgi Petrov, gogothebee at gmail.com
> + *  @date   31.10.2008
> + *  @return N/A
> + */
> +void ToogleFullscreen()

Do we need the author information duplicated in all those places?  You
should put it in one central place instead.

> +int D3DConfigure ()

This needs to be

  int D3DConfigure (void)

same in other places...

Some of your lines are excessively long, keeping them below 80
characters will earn you extra good karma.

Diego