[MPlayer-dev-eng] [PATCH] fix v4l2 free_demuxer crash - uvcvideo

[Vladimir Voroshilov]

2008/5/30 Ötvös Attila <dc at chello.hu>:
> Hi All!
>
> This patch fix v4l2 free_demuxer crash to uvcvideo usb video driver.
>
>Index: stream/tvi_v4l2.c
>===================================================================
>--- stream/tvi_v4l2.c	(revision 26920)
>+++ stream/tvi_v4l2.c	(working copy)
>@@ -1089,6 +1089,7 @@
>         struct v4l2_buffer buf;
>
>         /* get performance */
>+        if(priv->standard.frameperiod.denominator && priv->standard.frameperiod.numerator)
>         frames = 1 + (priv->curr_frame - priv->first_frame +
>                       priv->standard.frameperiod.numerator * 500000 /
>                       priv->standard.frameperiod.denominator) *

This means that drivers reports frameperiod==0.
I didn't found any requirenments for non-zero frameperiod in V4L2 spec
does, though.
But even if  such value is allowed (which sounds strange for me),
above solution is incomplete,
because frameperiod is used in other places, too (e.g. A/V sync code).

Are here any v4l2 specialists?
What do you think ?

Fixing uvcvideo drivers looks more reasonable, imho.

-- 
Regards,
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719