[MPlayer-dev-eng] [PATCH] add slave command for stop playback without to quit MPlayer (useful with -idle)

[Mathieu SCHROETER]

Hi,

Diego Biurrun a écrit :
> On Thu, Mar 06, 2008 at 06:36:13PM +0100, Mathieu SCHROETER wrote:
>> --- DOCS/tech/slave.txt	(r??vision 26185)
>> +++ DOCS/tech/slave.txt	(copie de travail)
>> @@ -266,6 +266,9 @@
>>  
>> +stop
>> +    Stop the playback.
> 
> Stop playback.

Ok.

>> --- DOCS/man/en/mplayer.1	(r??vision 26185)
>> +++ DOCS/man/en/mplayer.1	(copie de travail)
>> @@ -232,6 +232,8 @@
>> +.IPs "U\ \ \ \ "
>> +Stop playing (and quit if -idle not used).
> 
> Stop playing (and quit if \-idle is not used).

Ok, I've also fixed in the french part.

>> --- mplayer.c	(r??vision 26185)
>> +++ mplayer.c	(copie de travail)
>> @@ -3974,6 +3974,9 @@
>>        mpctx->playtree_iter = NULL;
>>      }
>>     }
>> +} else if (mpctx->eof == PT_STOP) {
>> +  play_tree_iter_free(mpctx->playtree_iter);
>> +  mpctx->playtree_iter = NULL;
>>  } else { // NEXT PREV SRC
>>       mpctx->eof = mpctx->eof == PT_PREV_SRC ? -1 : 1;
>>  }
> 
> Please indent this code with 4 spaces where appropriate.

Mmmmh.. I think that the problem is not the indent of my patch
but the lines 3976 and 3981 (with patch applied). The line 3976 uses
3 spaces and the line 3981 uses 5 spaces.
All others lines of this "if {} else if {} [...] else {}"
use *2* spaces.

In this case I propose a cosmetic patch at least for this part.


Sorry for my crappy english.

Regards,
Mathieu SCHROETER

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1_add_cmd_stop_for_slave_r1.patch
Type: text/x-patch
Size: 3599 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080307/fa8bb24a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2_cosmetic_fix_indentation.patch
Type: text/x-patch
Size: 519 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080307/fa8bb24a/attachment-0001.bin>