[MPlayer-dev-eng] Fwd: Re: [PATCH] add optional device with dvd://

Mathieu SCHROETER mathieu.schroeter at gamesover.ch
Fri Jul 4 18:14:37 CEST 2008


Nico Sabbi a écrit :
> Il giorno ven, 04/07/2008 alle 17.53 +0200, Nico Sabbi ha scritto:
>> From: Mathieu SCHROETER <mathieu.schroeter at gamesover.ch>
>> To: mplayer-dev-eng at mplayerhq.hu
>> Date: Thu, 03 Jul 2008 12:47:49 +0200
>> Subject: Re: [MPlayer-dev-eng] [PATCH] add optional device with dvd://
>> Mathieu SCHROETER a écrit :
>>> +  if(!p->device)
>>> +    dvd_device_current = strdup(dvd_device ? dvd_device :
>> DEFAULT_DVD_DEVICE);
>>
>> Sorry previous patch is wrong because a leak exists on
>> dvd_device_current. Now strdup() is only used on dvd_device
>> (if necessary)...
> 
> thanks, applied in pieces, but guy: you like to make
> controls a bit complicated with all those ! conditions
> (that I simplified)
> 

Thanks but there is a good reason.. I explain in the cvslog list.

Regards,
Mathieu




More information about the MPlayer-dev-eng mailing list