[MPlayer-dev-eng] [PATCH] DVDNAV Still frames supprt

[Reimar Döffinger]

Hello,
On Fri, Jan 25, 2008 at 08:51:47PM +0100, Benjamin Zores wrote:
> Reimar Döffinger a écrit :
>
>> Note that this is only a very quick review, I have not truly understood
>> even half of the code...
>
> Attached an updated patch.
> This is much more likely to be understood.

Yes, looks like good cleanup to me.

> @@ -237,6 +286,10 @@
>      int event;
>  
>      dvdnav_priv_t* priv=s->priv;
> +    if (priv->state & NAV_FLAG_WAIT_READ) { /* read is suspended */
> +      len = -1;
> +      return len;
> +    }

I guess this is this way because it will be extended later? If not that
should be just return -1; and without the {} I think.

Greetings,
Reimar Döffinger