[MPlayer-dev-eng] [PATCH] Correctly support 32-bit raw MOV

Diego Biurrun diego at biurrun.de
Thu Jan 24 00:15:29 CET 2008


On Wed, Jan 23, 2008 at 07:47:46PM +0800, Timothy Lee wrote:
> > On Wed, Jan 23, 2008 at 06:28:40PM +0800, Timothy Lee wrote:
> >   
> >> I've re-implemented the support for RGB32x and BGR32x colorspace inside
> >> libswscale as per Michael's suggestions.  This updated set of patches does
> >> the following:
> >>
> >>    * libswscale-rgb32x.patch -- adds support for RGB32x -> BGR32 and
> >>      BGR32x -> RGB32 conversion using 32-bit byte-swapping.
> >>    * vd-rgb32x.patch --  modifies the filter chain construction process
> >>      to automatically insert another vf_scale when the vo does not
> >>      support RGB32x or BGR32x colorspace.
> >>    * mov-raw-32bit.patch -- fixes the colorspace of 32-bit raw RGB
> >>      video reported by MOV demuxer.
> >>
> >> Again, the code has not been tested on big-endian machines.
> >>     
> > If you tell me exactly what to test, I can give this a go.
> >   
> I've already uploaded a test file to 
> ftp://upload.mplayerhq.hu/MPlayer/incoming/aletrek-raw-32bit.mov.

Moved to

http://samples.mplayerhq.hu/mov/rawvid/aletrek-raw-32bit.mov

> An unpatched mplayer would play it back with a reddish tint.
> After applying the patch, the background of the movie clip should be 
> black, and the clothing of the cartoon characters should be red.  Since 
> the extra vf_scale is inserted automatically, there is no need for 
> additional command line parameters.

An unpatched PPC MPlayer gives me a black background and blue clothing.

Applying just libswscale-rgb32x.patch makes no difference.
Applying vd-rgb32x.patch afterwards makes no difference either.
Applying mov-raw-32bit.patch afterwards gives the whole image a blueish
tint.

Diego



More information about the MPlayer-dev-eng mailing list