[MPlayer-dev-eng] [PATCH] Allow sub_scale command to work with ASS subtitle renderer

[Evgeniy Stepanov]

On Tuesday 22 January 2008 01:25:51 Benjamin Zores wrote:
> Hi,
>
> Attached patch does $subject.
> Can libass and mp_command maintainers review it ?

Maybe I'm missing something trivial, but why can't ass_set_font_scale() be 
called directly from property code, avoiding all this mess with 
ass_force_reload ? This will also work with vf_vo.

Adding a separate property for ass font size makes sense, but I don't have a 
strong opinion here. Sub_scale and ass_font_scale are different: the first 
one defines subtitle font size (maybe relative to video dimensions), while 
the last is a multiplier for the value read from subtitle file. From 
usability standpoint, it seems fine to increase/decrease them both with one 
key, but setting them to the same value does not make sense. Maybe this 
property should work with some internal multiplier and apply it to both 
ass_font_scale and text_font_scale_factor ? This way they will be changed 
simultaneously, but with separate base values.