[MPlayer-dev-eng] [PATCH] lavf demuxer: always overwrite codec_tag for PCM formats

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Jan 19 15:51:52 CET 2008


Hello,
On Sat, Jan 19, 2008 at 03:21:14PM +0100, Roberto Togni wrote:
> On Sun, 13 Jan 2008 18:40:21 +0100
> Roberto Togni <rxt at rtogni.it> wrote:
> >  currently demuxer_lavf fails to set the correct codec format for some
> > pcm files (eg. .au files, see samples/au/vrooom.au). This happens
> > because the demuxer fills codec_tag with the tag used in the file (2
> > for vrooom.au), and so MPlayer does not look into the codec_id =>
> > codec_tag table to fix it. Also in this case the original codec_tag is
> > already used by MPlayer (ms dpcm).
> > lavf demuxer set the codec_id to the right format for pcm codecs.
> > 
> > This patch forces demuxer_lavf to ignore the codec_tag for pcm formats,
> > and to always replace it with a tag computed from the CODEC_ID_PCM_*
> > value.
> > 
> > It fixes the vrooom.au file and works with the other files I've tested.
> > 
> 
> Updated version attached. I'll apply it soon if no complaints.

Not really, but I'd say just go ahead and apply, it is better than what
is done currently despite my nit-picking.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list