[MPlayer-dev-eng] [PATCH] mmap support for OS/2

[KO Myung-Hun]

Hi/2.

Diego Biurrun wrote:
> On Mon, Feb 25, 2008 at 10:41:08AM +0900, KO Myung-Hun wrote:
>   
>> Diego Biurrun wrote:
>>     
>>> On Mon, Feb 25, 2008 at 01:12:56AM +0900, KO Myung-Hun wrote:
>>>   
>>>       
>>>> This patch add a simple mmap support for OS/2.
>>>>
>>>> --- osdep/mmap.h	(revision 0)
>>>> +++ osdep/mmap.h	(revision 0)
>>>> @@ -0,0 +1,73 @@
>>>> +
>>>> +/* MAP_FAILED is defined in config.h */
>>>> +#if 0
>>>> +/*
>>>> + * Error return from mmap()
>>>> + */
>>>> +#ifndef MAP_FAILED
>>>> +#define MAP_FAILED  ((void *)-1)
>>>> +#endif
>>>> +#endif
>>>>         
>>> I don't like #if 0 code...
>>>       
>> Instead, commented it out.
>>     
>
> That's no better.  I meant that I don't like committing code that is off
> by default.  

Ok.

> Why is it there in the first place?
>
>   

Ah, it's simple. Unlike you, I prefer to preserve the codes if there is 
no big problem.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.8
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 750 MHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mmap.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20080225/c057b600/attachment.txt>