[MPlayer-dev-eng] [PATCH] getch2() support for OS/2

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Feb 20 13:59:36 CET 2008


Hello,
On Wed, Feb 20, 2008 at 09:20:35PM +0900, KO Myung-Hun wrote:
>> I do not like this renaming at all, this is still code that is full of
>> Windows-API stuff. Sure it is used for OS/2 as well, but is is still the
>> Windows API it uses, so the previous name still seems more correct.
>>   
>
> I agree with you. But it seems that Alban and Diego want it.

Well, with the reasoning in that mail it actually makes sense.
I would slightly prefer if whoever applies this first renames
the mp_input_win32_slave_cmd_func and then applies the rest, but it's
not too important.



More information about the MPlayer-dev-eng mailing list