[MPlayer-dev-eng] [PATCH] getch2() support for OS/2

Diego Biurrun diego at biurrun.de
Mon Feb 18 18:58:49 CET 2008


On Tue, Feb 19, 2008 at 02:17:37AM +0900, KO Myung-Hun wrote:
> 
> This patch add getch2() support for OS/2.
> 
> --- osdep/getch2-os2.c  (revision 0)
> +++ osdep/getch2-os2.c  (revision 0)
> @@ -0,0 +1,204 @@
> +/*
> + * getch2-os2.c : OS/2 TermIO for MPlayer
> + *
> + * Copyright (c) 2007 KO Myung-Hun (komh at chollian.net)
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA

Replace "this program" with "MPlayer".

> + *
> + * Changes :
> + *     KO Myung-Hun <komh at chollian.net> 2007/10/28
> + *         - Support new type getch2()
> + *
> + *     KO Myung-Hun <komh at chollian.net> 2008/01/26
> + *         - Support 'Keypad Enter'

This changelog is pointless.

> +#define INCL_KBD
> +#define INCL_VIO
> +#define INCL_DOS

These are not defined anywhere.

> --- osdep/getch2.h  (revision 26012)
> +++ osdep/getch2.h  (working copy)
> @@ -28,4 +28,8 @@
>  
> +#ifdef __OS2__
> +extern int mp_input_os2_slave_cmd_func(int fd,char* dest,int size);
> +#endif

pointless #ifdef

Diego



More information about the MPlayer-dev-eng mailing list