[MPlayer-dev-eng] [PATCH] Base patches for OS/2 support

[Rich Felker]

On Mon, Feb 18, 2008 at 10:14:04AM +0100, Diego Biurrun wrote:
> On Mon, Feb 18, 2008 at 12:47:06PM +0900, KO Myung-Hun wrote:
> > 
> > I try another patch for OS/2 support. This is a base patch for others.
> 
> Basically looks good except for
> 
> > --- configure	(revision 26012)
> > +++ configure	(working copy)
> > @@ -7544,6 +7628,9 @@
> >  if cygwin ; then
> >    CFLAGS="$CFLAGS -D__CYGWIN__"
> >  fi
> > +if os2 ; then
> > +  CFLAGS="$CFLAGS -Zomf -DSYS_OS2"
> > +fi
> 
> What do you use SYS_OS2 for?  It seems to be just one extra level of
> indirection for __OS2__.  Just use __OS2__ directly then.

FWIW, I'm against ANY direct use of __-prefixed preprocessor symbols.
It hardcodes lots of nasty implementation-specific knowledge in the C
source files and makes it very hard to use a different compiler or
build environment on the same (or similar) system. Instead, the
implementation-specific knowledge (gathered from the __ symbols)
should be tucked away in the configure script and the actual C source
files should use preprocessor symbols reserved to the application.

Rich