[MPlayer-dev-eng] [PATCH v2] support sub_pos in libass

Evgeniy Stepanov eugeni.stepanov at gmail.com
Thu Dec 25 13:20:49 CET 2008


On Wednesday 24 December 2008 20:22:10 Rafał Miłecki wrote:
> OK, I tried to fix reported issues and hopefully done it right.
>
> Is this one acceptable?
>
> 01 and 02 touch libass only. 03 makes use of this new feature which is
> sub_precentpos :)

Why do you change sub_percentpos in ass_start_frame??
And why is it in global_settings, and not in ass_style_t?

Also, I think you don't need ass_sub_percentpos in ass_mp.c. You can use 
sub_pos directly.

And 14 should be VALIGN_PERCENTPOS | HALIGN_CENTER.




More information about the MPlayer-dev-eng mailing list