[MPlayer-dev-eng] [PATCHES] vidix: SuperH fixes, NV12 support, new vidix driver

[Benjamin Zores]

Magnus Damm wrote:
> On Thu, Aug 7, 2008 at 9:10 PM, Benjamin Zores <ben at geexbox.org> wrote:
>> + * Requires a kernel that exposes the VEU hardware block to user space
>> + * using UIO. Available in upstream linux-2.6.27 or later.
>>
>> But if so, configure needs to check for linux 2.6.27+ kernel to enable
>> this driver build.
> 
> Sorry for being unclear, but that's a run time dependency.
> 
> There are no special build dependencies. I think the current behavior
> with not checking makes sense since there is already a clear
> separation between build and run time. For instance, the other vidix
> drivers doesn't check if such a pci driver is enabled in the kernel,
> right?
> 
> I guess most people who may be interested in this driver will cross
> compile, so the kernel version check doesn't help much there either.
> 
> Or do you really want me to add a check to the configure script?

Ok, I've reviewed it quickly and I confirm that 2.6.27+ is runtime 
dependancy only has it just tries to read /sys/... file.

Though, I think that configure needs to ensure that only Linux target
will build the driver (like it's done for ivtv vidix driver) and 
preferably only when building for sh arch.

I have no other objection regarding the vidix patch itself, except that 
I'd rather have seen snprintf() than sprintf() wherever it's possible.

Ben