[MPlayer-dev-eng] Indentation style (was: [PATCH] Fix useless dependencies in the stream lib)

Diego Biurrun diego at biurrun.de
Wed Apr 9 00:21:34 CEST 2008


On Tue, Apr 08, 2008 at 11:11:02PM +0300, Uoti Urpala wrote:
> On Tue, 2008-04-08 at 21:31 +0200, Alban Bedel wrote:
> > We don't really need everybody to agree. If some maintainer hate tags
> > for some reason he is free to forbid them in the files he maintain.
> > For files without maintainer obviously we will need some consensus, but
> > I doubt that debating adding a few comments would be as inflammatory as
> > breaking a long established tradition.
> 
> I think letting "the maintainer" decide on use of non-standard tags is a
> major problem with your proposal. The maintainer list often does not
> reflect who in practice works on the files; and IMO we do not want the
> bureaucracy to maintain a really authoritative list. In practice there
> is rarely only a single person who would work on a file. We'd need a
> better way to decide how to set the tags if there is any disagreement.
> And overall I think trying to set authority over code on a per-file
> basis is a bad idea.

I agree completely.  We would just be shifting the problem from
discussing formatting to discussing tags.

In any case, AFAICT, the files with the worst indentation are those
maintained by all/none...

Diego



More information about the MPlayer-dev-eng mailing list