[MPlayer-dev-eng] [PATCH] Fix dependencies between muxer and demuxer

[Diego Biurrun]

On Tue, Apr 08, 2008 at 07:53:09PM +0200, Alban Bedel wrote:
> On Tue, 8 Apr 2008 18:25:19 +0200
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > On Tue, Apr 08, 2008 at 06:14:10PM +0200, Alban Bedel wrote:
> > > On Tue, 8 Apr 2008 01:25:33 +0200
> > > Diego Biurrun <diego at biurrun.de> wrote:
> > > 
> > > > On Mon, Apr 07, 2008 at 02:49:56PM +0200, Alban Bedel wrote:
> > > > > 
> > > > > following my previous post, now are fixes for vivodump. They
> > > > > allow to use libmpmux without libmpdemux.
> > > > > 
> > > > > --- libmpdemux/Makefile	(revision 26343)
> > > > > +++ libmpdemux/Makefile	(working copy)
> > > > > @@ -36,6 +36,7 @@
> > > > >                extension.c \
> > > > >                mf.c \
> > > > > +              aac_hdr.c \
> > > > >                mp3_hdr.c \
> > > > 
> > > > alphabetical order
> > > 
> > > Fixed, perhaps you should add comments in the Makefiles. I mean
> > > when one is busy with other things than Makefile layout, it's not
> > > necessarily obvious.
> > 
> > Add comments where?  DOCS/tech/svn-howto.txt?  Basically everything is
> > in alphabetical order in the Makefiles.  If it is not, it is a bug.
> 
> In the Makefile obviously. Sure it's obvious to you the Makefile
> maintainer. But for a random dev with his mind busied by other things
> (like getting his stuff done) it might easily be overlooked.
> It's a suggestion which I thought might lead to you having to reply
> "alphabetical order" less often. Now you do what you want with it.

It was an honest question.  I have no idea where you would expect such a
comment to be.  There are quite a few Makefiles in the tree, adding such
a comment to all of them is not really practical.  In any case, I'm
working on shuffling the Makefiles around quite a bit, probably towards
a single large Makefile.  I'll see what I can do once this is done.

Diego