[MPlayer-dev-eng] [PATCH] libnemesi support in mplayer

Diego Biurrun diego at biurrun.de
Fri Sep 7 01:34:40 CEST 2007


On Thu, Sep 06, 2007 at 08:37:18PM +0200, Luca Barbato wrote:
> Diego Biurrun wrote:
> > On Thu, Sep 06, 2007 at 02:09:31PM +0200, Luca Barbato wrote:
> >> @@ -6265,6 +6283,11 @@
> >>  fi
> >>  echores "$_live"
> >>  
> >> +if test "_nemesi" = no; then
> >> +  _no_inputmodules="nemesi $_no_inputmodules"
> >> +else
> >> +  _inputmodules="nemesi $_inputmodules"
> >> +fi
> > 
> > This should be next to the nemesi test, not at a random location.
> 
> it must be after the latest block touching $_nemesi

Yes, but not after the live555 test.

> >> +#endif
> > 
> > Please comment the #endif.
> 
> hmm

Please just make it read

#endif /* DEMUX_NEMESI_H */

All headers in FFmpeg do this.  If you find some in MPlayer that don't,
tell me and I will fix it.

Diego



More information about the MPlayer-dev-eng mailing list