[MPlayer-dev-eng] [PATCH] tv:// for win32

[Reimar Döffinger]

Hello,
On Tue, Oct 09, 2007 at 07:04:13PM +0700, Vladimir Voroshilov wrote:
> 2007/10/9, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > On Tue, Oct 09, 2007 at 04:33:49PM +0700, Vladimir Voroshilov wrote:
> > > 2007/9/8, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > > > [...]
> > > > A proper review will hopefully follow some other day soon... ;-)
> > >
> > > I'm still waiting ;)
> >
> > I think I lack the time for that, but I do have a few comments.
> 
> Should i assume that remaining code is acceptable for commit (IOW:
> other issues, if any,
> can be fixed after commit)?

Hmm.. seems I forgot to actually type it. I wanted to say: apply if you
think it is okay and nobody objects.

[...]
> > And lastly, are you sure "#pragma pack" works with gcc? Even if it does
> > I think it would be preferable if you could find the corresponding
> > attributes and use them, but I'll leave that up to you to decide in the
> > end (as long as they work with gcc and don't give ugly warnings at
> > least).
> 
> Yes it works,

Good to know, someone asked only a few weeks ago about that.

Greetings,
Reimar Döffinger