[MPlayer-dev-eng] [PATCH] Make vo_macosx support double buffering by default

[Tim Wojtulewicz]

On Oct 6, 2007, at 3:10 AM, Ulion wrote:

> 2007/10/6, Tim Wojtulewicz <timwoj at ieee.org>:
>>
>> It's using the ffmpeg wmv decoder.  I've made it happen with xvid/
>> divx avi as well.  The thing is that it's not easily reproducible.
>> It will happen sometimes, and not others.  I'll keep trying to see if
>> it's something specific like having the OSD visible or if it's
>> dependent on fast forwarding or rewinding during playback.
>>
>> In fact, as I was writing this I was trying to duplicate it, and I
>> got it to happen again.  The first file dumps this:
>>
>> VIDEO:  [XVID]  640x352  12bpp  25.000 fps  1190.7 kbps (145.4  
>> kbyte/s)
>> Clip info:
>> Software: VirtualDubMod 1.5.10.2 (build 2540/release)
>> ===================================================================== 
>> ===
>> ==
>> Opening video decoder: [ffmpeg] FFmpeg's libavcodec codec family
>> Selected video codec: [ffodivx] vfm: ffmpeg (FFmpeg MPEG-4)
>> ===================================================================== 
>> ===
>> ==
>>
>> The first file is about an hour long so I fast-forwarded to about 5
>> min from the end and let it play.  Sure enough, crashes in the same
>> place.  Tried the exact same thing again, no crash.  I'll let it play
>> through all the way once or twice.  Hopefully it still does it.
>
> OS version? XCode version?
> How about this?
>
> Index: libvo/vo_macosx.m
> ===================================================================
> --- libvo/vo_macosx.m   (revision 24704)
> +++ libvo/vo_macosx.m   (working copy)
> @@ -248,6 +248,7 @@
>      if(mpGLView)
>      {
>          [autoreleasepool release];
> +        mpGLView = nil;
>      }
>  }
>

OS 10.4.10
gcc version 4.0.1 (Apple Computer, Inc. build 5367)

I think that patch might be it.  I haven't gotten it to crash again  
since I rebuilt with that.  I'll try it for a couple of days and let  
you know.

Tim