[MPlayer-dev-eng] [PATCH] Use unrar for open vobsubs if available

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sat Nov 24 11:23:20 CET 2007


Hello,
On Sat, Nov 24, 2007 at 02:50:59PM +0800, Ulion wrote:
> We already discussed the libunrar patch, that was linked to mplayer so
> it's rejected.
> But we can safely use external decompress tool 'unrar' for this purpose.

Please before writing a patch search the archives carefully, there were
at least three different attempts in the past, we do not need another
flawed implementation of the same thing, we need a proper one.
And honestly a proper solution will most likely have to clean up the
_unspeakable utter and complete mess_ the current code is (the one using
unrarlib, well, actually unrarlib itself probably is a mess as well).
An additional point is that I am not at all too happy about spending
time improving support for a proprietary format, but not
reverse-engineering it but instead jumping through all kinds of hoops
while not supporting any of the opensource compression formats that
would work as well if not better.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list