[MPlayer-dev-eng] [PATCH] split filter_n_bytes function a bit

[Uoti Urpala]

On Sat, 2007-11-03 at 15:16 +0100, Reimar Döffinger wrote:
> Hello,
> I for some reason didn't like that it does two mostly unrelated things:
> decoding to fill the in buffer with data and passing it through the
> filter chain.
> Attached patch patch would split it. Objections?

There are phases in the functionality but so there are in most
functions. IMO splitting the flow of the function into dozen-line
subfunctions is harmful.

Additionally your patch breaks the EOF/error logic.