[MPlayer-dev-eng] [PATCH] Make mp3lib SIMD optimizations work on AMD64, Part 5

Zuxy Meng zuxy.meng at gmail.com
Mon May 28 10:35:04 CEST 2007


Hi,

2007/5/28, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Mon, May 28, 2007 at 09:57:14AM +0800, Zuxy Meng wrote:
> > 2007/5/26, Zuxy Meng <zuxy.meng at gmail.com>:
> > > I've tested the patch on IA-32 and AMD64 (thanks to Stefan's testbed!)
> > > and no regression has been found.
> >
> > Would u help review the new patch, Reimar?
>
> While I am not entirely convinced that all of it is necessary the patch
> seems okay to me.
> Except maybe that you use once *(unsigned*)hbuf and once
> *(uint32_t*)hbuf, I'd consider using the same in both cases.

Will be corrected. Is the rest OK to apply?
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6



More information about the MPlayer-dev-eng mailing list