[MPlayer-dev-eng] [PATCH] Fix LIRC input

Alban Bedel albeu at free.fr
Sat May 19 21:44:17 CEST 2007


On Sat, 19 May 2007 21:18:58 +0200
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> Hello,
> On Sat, May 19, 2007 at 09:09:57PM +0200, Benjamin Zores wrote:
> >  Attached patch seems to be needed by some LIRC remotes to work properly.
> >  It doesn't seem to harm any other place of input code (i.e. keyboard still 
> >  works, so does joystick and remotes that used to work with current code 
> >  continue to do so without these 2 lines).
> > 
> >  Anyone's against this patch ?
> 
> Until it is entirely clear what exactly it does, yes, I am absolutely
> against it.

It's definitly wrong, the pb is somewhere else. This loop is cheking fds where
a simple select() can be used wich is not the case with lirc because of it's
broken design.

	Albeu




More information about the MPlayer-dev-eng mailing list