[MPlayer-dev-eng] Re: libdvdnav

[Diego Biurrun]

On Wed, Mar 14, 2007 at 06:12:19PM +0100, ?tv?s Attila wrote:
> 
> The 3-dvdnav.patch patch modifies the configure and Makefile so internal 
> dvdnav can build.

I haven't looked at this in detail yet, just some quick remarks:

> --- dvdnav/Makefile	 (none)
> +++ dvdnav/Makefile	 (working copy)

There's no sense in reviewing this file in detail.  It's completely
redundant.  You should reuse mpcommon.mak like the other Makefiles do.

> --- dvdnav/config.h	 (none)
> +++ dvdnav/config.h	 (working copy)
> @@ -0,0 +1,8 @@
> +/* Let it be for now*/
> +#define DVDNAVSVERSION "0.1.10"
> +#include "../config.h"
> +#include "../mp_msg.h"
> +#include "../help_mp.h"
> +#ifdef USE_DVDNAV_TRACE
> +extern int dvdnav_trace;
> +#endif

We already have a config.h in the root directory, use that one instead
of adding another one here.

Diego