[MPlayer-dev-eng] [PATCH] dvdnav - wait, still frame, change audio and spu (nav)

[Ötvös Attila]

2007. március 9. 00.53 dátummal Nico Sabbi ezt írta:
> please, describe in detail what every patch is supposed to do and
> comment the code. How can we review such huge changes without comments'
Hi Nico Sabbi!

My main modifies are in dvdnav.patch:

1, Wait, still frame in stream_dvdnav.c

If wait or still frame is then the fill_buffer() in stream_dvdnav.c returnes 
with -1 readed bytes. 
At other streams are an eof but there it is needed to call 
mp_dvdnav_isreallyeof() so that stream is really eof.
If the video pts is greater than cell the duration clear wait or still frame 
event will be cleared.
If the duartion isn't setted (still_length=255) then will be only cleared id 
the activate of menu button will be.
The wait event is such as the still frame bacause of wait_read flag, but it 
needn't use in open demuxer (wait_read_automode=0).

2, Wait, still frame is mplayer.c

If wait or still frame is then mplayer decodes last read video frame.
Mplayer store the decodes frame and after it this uses such as decoded_frame.
At the first the decoding is usually unsuccessful so it have to probe several 
times (x5).
The mp_dvdnav_decode_video_pre() and mp_dvdnav_decode_video_post() do this.

3, Audio channels, subtitles and SPU menu buttons in mplayer.c

The mp_dvdnav_audio_handle() does the audio channel is use change.
The mp_dvdnav_spu_handle() does the subtitle channel is use change.
The mp_dvdnav_highlight_handle() does the SPU menu buttos is use change.

4, The properties of the are audio channels in stream_dvdnav.c

Now, the audio attr in dvdnav can't be queried..
The mp_dvdnav_set_audio_channels() tries to make it on the basis of dvdnav and 
demuxer audio id.

I append comments to dvdnav.patch.

Best regards!
Attila
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dvdnav.patch
Type: text/x-diff
Size: 37967 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070310/7644c0e0/attachment.patch>