[MPlayer-dev-eng] Re: PATCH [7/12] CoreAVC support (Take 3)

[Reimar Döffinger]

Hello,
On Sun, Mar 04, 2007 at 07:42:20AM -0800, Alan Nisota wrote:
> Reimar Döffinger wrote:
> >On Sat, Mar 03, 2007 at 09:48:47PM -0800, Alan Nisota wrote:
> >>Reimar Döffinger wrote:
> >>>I looked at the documentation and this code still looks overcomplicated
> >>>and wrong to me.
> >>>Can you test attached patch?
> >>>
> >>Yes, that works fine.  I've included an updated patch which includes 
> >>yours plus identical changes to MultiByteToWideChar
> >
> >Applied then.
> I just noticed that there is an 'expMultiByteToWideChar' in win32.c 
> which looks very wrong to me.  Would it be appropriate to replace this 
> with a call to the updated MultiByteToWideChar you just committed?

Fine by me, just test it with a few binary decoders to make sure they
don't need it to be broken. Testing is always such as hassle for me
since my 32bit mplayer is never up-to-date.

Greetings,
Reimar Döffinger