[MPlayer-dev-eng] configure: athlon-xp is mistakely detected as athlon

Diego Biurrun diego at biurrun.de
Thu Mar 1 15:44:28 CET 2007


On Thu, Mar 01, 2007 at 12:45:00AM +0100, Guillaume POIRIER wrote:
> 
> On 2/28/07, Andrew Savchenko <Bircoph at list.ru> wrote:
> >On 26 Feb 2007 14:59 mail at kraymer.de wrote:
> >> Andrew Savchenko wrote:
> >> >
> >> > In r22301 configure script selects between athlon-xp and
> >> > athlon by testing for sse support, but extensions check (and
> >> > particularly  sse check) is performed _after_ check for GCC &
> >> > CPU optimization  abilities. So there is no way for propely
> >> > autodetection of> athlon-xp: it will be always auotodetected
> >> > as athlon.
> >> >
> >> > Attached patch just moves extensions check _before_ check for
> >> > CPU abilities. It works fine for me. Please review.
> >>
> >> Looking at configure output, this patch appears to be working
> >> here too. Thanks, I hadn't even noticed that athlon-xp wasn't
> >> detected properly.
> >
> >So, are there any objections? Can someone apply it?
> 
> Seems Ok with me. Diego, can I apply it?

Seems to be OK, yes.  If you apply it, maybe add a small explanatory
comment in front of it.

Diego



More information about the MPlayer-dev-eng mailing list