[MPlayer-dev-eng] [PATCH] get rid of my_memcpy_pic code duplication

Reimar Doeffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Jun 25 10:05:23 CEST 2007


Hello,
On Sun, Jun 24, 2007 at 09:33:01PM +0200, Michael Niedermayer wrote:
> On Sun, Jun 24, 2007 at 02:58:09PM +0200, Reimar Döffinger wrote:
> > Seems rather stupid that each filter has this filter copy-and-pasted
> > (esp. since they also do void * arithmetic).
> > I have not properly benchmarked it, but I don't think there is even a
> > real need for those functions to be static inline at all.
> > Ok to apply?
> 
> IMHO yes but i think my_memcpy_pic() should be renamed after that, its name is
> not really related to the difference to memcpy_pic()

Sure, I was just lazy to do all the changing right now.
Have a good suggestion for a name?
In addition vf_divtc.c needs to be changed as well because it needs a
function pointer, but just adding a local stub for memcpy_pic is a good idea
anyway since the current version is not exactly clean (casts memcpy_pic
to a function pointer with one argument more).

> also i would rename forceskip to limit2width

Sure, I'm not too good at coming up with names.

Greetings,
Reimar Doeffinger



More information about the MPlayer-dev-eng mailing list