[MPlayer-dev-eng] [PATCH] remove global variables from gif demuxer

[Diego Biurrun]

On Fri, Jan 12, 2007 at 08:28:32PM +0100, Reimar Döffinger wrote:
> On Fri, Jan 12, 2007 at 08:23:02PM +0100, Reimar D?ffinger wrote:
> > does this (untested) patch look good to you?
> 
> Sorry, attached version is better...

I like it, but this seems to conflict with the fixes by John Koleszar,
which should go in ...

> --- libmpdemux/demux_gif.c	(revision 21888)
> +++ libmpdemux/demux_gif.c	(working copy)
> @@ -118,10 +122,10 @@
>  
>      // copy the pallete
>      for (y = 0; y < 256; y++) {
> -	pallete[(y * 4) + 0] = effective_map->Colors[y].Blue;
> -	pallete[(y * 4) + 1] = effective_map->Colors[y].Green;
> -	pallete[(y * 4) + 2] = effective_map->Colors[y].Red;
> -	pallete[(y * 4) + 3] = 0;
> +	priv->palette[(y * 4) + 0] = effective_map->Colors[y].Blue;
> +	priv->palette[(y * 4) + 1] = effective_map->Colors[y].Green;
> +	priv->palette[(y * 4) + 2] = effective_map->Colors[y].Red;
> +	priv->palette[(y * 4) + 3] = 0;

Nice spelling fix you snuck in there ;)

Diego