[MPlayer-dev-eng] [PATCH] VCD support for Windows (except Win9x)

[Reimar Döffinger]

Hello,
On Mon, Feb 26, 2007 at 09:49:10PM +0800, Zuxy Meng wrote:
> 2007/2/26, Compn <tempn at twmi.rr.com>:
> >On Mon, 26 Feb 2007 21:37:40 +0800,
> >Zuxy Meng scribed:
> >
> >> +#ifdef WIN32
> >> +  HANDLE hd;
> >> +  char device[] = "\\\\.\\D:";
> >> +#endif
> >
> >does this hardcode the device name?
> >D: is not the dvd/cdrom drive on all systems.
> 
> D is only a stub here. The actual letter is filled by:
> +  device[4] = p->device[0];

With any sane combination of compiler and operating system this should
crash. String constants are supposed to be in readonly memory.

Greetings,
Reimar Döffinger