[MPlayer-dev-eng] [PATCH] Add mouse support for DVDNAV under Windows

[Zuxy Meng]

Hi,

2007/2/8, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Thu, Feb 08, 2007 at 09:26:00PM +0800, Zuxy Meng wrote:
> > 2007/2/8, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > >On Thu, Feb 08, 2007 at 08:15:58PM +0800, Zuxy Meng wrote:
> > >> With the patch user can use mouse to select dvdnav menu buttons under
> > >> Windows. Currently for '-vo gl' and '-vo gl2' only, although
> > >> supporting the default '-vo directx' won't be hard, but I wish we can
> > >> simply merge the two WndProc in w32_common.c and vo_directx.c.
> > >
> > >I'm not sure merging is possible or desirable, but I guess you could
> > >make vo_directx call the win32_common one instead of the default window
> > >proc and reuse it this way.
> >
> > I was thinking about:
> > in vo_directx:
> > ...WndProc()
> > {
> >    switch(msg)
> >    {
> >     case xxx:
> >      ...
> >      break;
> >     case yyy:
> >      ...
> >      break;
> >     default:
> >      return Win32WndProc(msg, ...)
> >    }
> >    return DefWindowProc(msg, ...)
> > }
>
> Yes, that's in principle what I had in mind (I know, what I said was a
> bit different ;-) ).
>
> > >It will require adjusting the build system, too.
> > >If the windowsx include is required only for WM_MOUSEMOVE it might be
> > >worth considering to just define it. Or is it absolutely certain
> > >windowsx.h is available everywhere?
> >
> > I'm not sure, just saw it in vo_directx.c so thought it would be safe.
>
> If it's used in vo_directx already it's fine, but why is it actually
> needed? WM_MOUSEMOVE is in winuser.h for me, which windows.h includes...

For the GET_X_LPARAM and GET_Y_LPARAM macros, as M$ has suggested.
-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6