[MPlayer-dev-eng] Better handling of low FPS and still images

Ivo ivop at euronet.nl
Thu Aug 30 22:09:56 CEST 2007


On Friday 24 August 2007 17:42, Ivo wrote:
> On Friday 24 August 2007 17:13, Ivo wrote:
> > On Friday 24 August 2007 16:50, Ivo wrote:
> > > On Friday 24 August 2007 16:31, Diego Biurrun wrote:
> > > > On Fri, Aug 24, 2007 at 04:26:05PM +0200, Ivo wrote:
> > > > > - version.sh fails on MinGW because there is no svn client
> > > >
> > > > version.sh does not depend on a svn client.
> > >
> > > I see. I just quickly glanced at the file. But it's actually cd "$1"
> > > that fails, because $1 is gcc's version number that is passed to
> > > version.sh
> >
> > I fail to see what the purpose of cd "$1" was in the first place, so
> > here's a patch that fixes version.sh.
> >
> > The grep/cut and sed versions also fail on MinGW/MSYS because
> > .svn/entries written by cygwin's svn (version 1.4.3) is not in XML
> > format. The fourth method I added does work though.
>
> Here's a better version of the patch I previously posted. The sed method
> works, but MinGW's sed needs an extra ;

Diego, is this OK to apply?

BTW I figured out where the cd "$1" came from. ffmpeg's Makefile calls 
version.sh with $(SRC_PATH) but MPlayer's calls it with the compiler's 
version number.

Also, I could make it into two separate commits if you like. One for the 
removal of the cd and one for the addition of the ;

--Ivo



More information about the MPlayer-dev-eng mailing list