[MPlayer-dev-eng] [PATCH] further dvr-ms playback improvements

Dominik 'Rathann' Mierzejewski dominik at rangers.eu.org
Sat Sep 16 20:14:03 CEST 2006


On Saturday, 16 September 2006 at 19:58, John Donaghy wrote:
> >
> >There's a lot of cosmetic changes here. Please send them in a separate 
> >patch.
> 
> Without the changes to video.c the patch will have no effect. The
> update to video.c involves putting a whole block of code inside a
> conditional and consequently changing the indentation. Do you still
> want a separate patch for this?

Yes. Keep the indentation of the existing code for functional changes,
even if it does look messy for a while. This is essential for this patch
to be accepted, per http://www.mplayerhq.hu/DOCS/tech/patches.txt point 5.

Regards,
R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan



More information about the MPlayer-dev-eng mailing list