[MPlayer-dev-eng] Re: Add matroska v2 support

Federico Menarini federico.menarini at gmail.com
Fri Sep 15 17:10:14 CEST 2006


2006/9/15, Evgeniy Stepanov <eugeni.stepanov at gmail.com>:
> Looks good, with 2 minor remarks:
> 1. demux_mkv.c uses spaces for indentation, so your patch should do the
> same.
> 2. A should comment, or a #define near
> if (!(flags&0x80))
> would be nice. Not many people remember what 0x80 stands for in SimpleBlock
> flags.

You're right, here is the corrected patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mkv.bin
Type: application/octet-stream
Size: 4300 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060915/8d554a70/attachment.bin>


More information about the MPlayer-dev-eng mailing list