[MPlayer-dev-eng] [PATCH] Filename double-conversion

[Zuxy Meng]

2006/10/26, Rich Felker <dalias at aerifal.cx>:
> On Wed, Oct 25, 2006 at 06:00:30PM +0800, Zuxy Meng wrote:
> > 2006/10/25, Zuxy Meng <zuxy.meng at gmail.com>:
> > >
> > >You remind me: mplayer still support MSG_CHARSET != UTF-8
> >
> > Revised patch attached.
>
> I like it except that the name filename_to_utf8 is misleading if the
> internal charset is not UTF-8. Calling it something like
> filename_recode might be more appropriate.

See if this looks better.

> Also:
>
> > +    if (!strcasecmp(mp_msg_charset, MSG_CHARSET) ||
> > +         !strcasecmp(mp_msg_charset, "noconv"))
>
> This assumes that mp_msg_charset is the same as the filesystem
> encoding. Any setup where that's not true is broken, but it might be
> good not to make the assumption anyway.
>
> Comments from any other developers??

Pending...

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: filename_utf8.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061030/588f20a4/attachment.txt>