[MPlayer-dev-eng] [PATCH] try to actually open demuxer in test

Evgeniy Stepanov eugeni.stepanov at gmail.com
Fri Oct 20 18:18:34 CEST 2006


On Thursday 19 October 2006 22:22, Reimar Döffinger wrote:
> Hello,
>
> On Sat, Oct 14, 2006 at 11:42:33PM +0200, Reimar D?ffinger wrote:
> > the attached patch makes the demuxer open function actually try to open
> > the file with a demuxer it detected and continue with others if it
> > fails.
> > This makes the dv-in-avi samples (at least
> > http://samples.mplayerhq.hu/avi/DV-hdr/foo001.avi) work out of the box
> > by falling back to libavformat demuxing.
> > Please test and check for stupid errors, that code somehow made my head
> > spin.
>
> Applied.

As I mentioned in -cvslog, it breaks tv:// playerback. This happens because tv 
demuxer does not have check_file() function. After your change open() is 
never called for such demuxers.

I suggest this simple fix. Please review it carefully, I'm not sure this does 
not break something else.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: demuxer-check_file.patch
Type: text/x-diff
Size: 996 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20061020/97c3ad13/attachment.patch>


More information about the MPlayer-dev-eng mailing list