[MPlayer-dev-eng] [PATCH] add support for all current and future x264 options

Guillaume POIRIER poirierg at gmail.com
Wed Oct 4 10:09:13 CEST 2006


Hi,

On 10/4/06, Loren Merritt <lorenm at u.washington.edu> wrote:
> On Mon, 2 Oct 2006, Guillaume POIRIER wrote:
> > On 10/2/06, Loren Merritt <lorenm at u.washington.edu> wrote:
> >>
> >> libx264 already contains code to parse options
> >> symbolically, no need to duplicate it in mencoder.
> >> However, some of the older options didn't use the same names between
> >> mencoder and x264cli, so they would have to change.
> >
> > Didn't you add synonym support to x264 a few minutes ago?
> >
> > Maybe it's a stupid proposition, but could mencoder's options be added
> > to x264's parser as synonyms of x264 options?
>
> Ok, with this patch most of the option names are the same. The ones that
> couldn't be fixed with synonyms are:
>
> deblockalpha, deblockbeta -> deblock
> a command that was "deblockalpha=$A:deblockbeta=$B" becomes "deblock=$A,$B".
> "nodeblock" still disables it, and "deblock" still enables it without
> changing the parameters.
>
> 4x4mv, 8x8mv, b8x8mv, i4x4, i8x8 -> partitions
> what was "4x4mv:8x8mv:b8x8mv:i4x4:i8x8" becomes "partitions=all" or
> "partitions=p4x4,p8x8,b8x8,i4x4,i8x8".
> what was "no4x4mv:no8x8mv:nob8x8mv:noi4x4:noi8x8" becomes
> "partitions=none" or "partitions=".

Well this has the nice advantage that it groups together options that
are related. :)



> direct_pred and me now take names instead of numbers.
> direct_pred: 0,1,2,3 -> none, spatial, temporal, auto.
> me: 1,2,3,4 -> dia, hex, umh, esa.

Numbers tend to be slitly more user friendly as ppl can easily
remember that "the higher, the better", so I tend to like them, but
having explicit names instead is Ok too IMHO.


> global
> I could have synonized this, but it needs renaming anyway. "global_header"
> is better.

I agree.

You're the maintainer of this file, feel free to commit your changes
whenever you feel like it.

Guillaume
-- 
With DADVSI (http://en.wikipedia.org/wiki/DADVSI), France finally has
a lead on USA on selling out individuals right to corporations!
Vive la France!



More information about the MPlayer-dev-eng mailing list