[MPlayer-dev-eng] [PATCH] disable mediaLib by default and make test Solaris-only

Ivan Kalvachev ikalvachev at gmail.com
Fri May 12 14:21:35 CEST 2006


2006/5/12, Derek E. Lewis <dlewis at solnetworks.net>:
> I don't understand what's wrong with the way its been disabled.  If the
> user wishes to enable (obviously, for some stupid reason) it, they can
> specify --enable-mlib and it'll force it to be enabled.  This is way
> things are and should be in 'configure'.  By default, it should be
> disabled as it adds no benefits for SPARC *or* x86.

Your way of disabling also skips the "--disable-mlib" path and skips
the inclusion of "#undef HAVE_MLIB" in config.h. The question why we
need undef is completely different topic ;)

The right way to disable it would be something like

+ if ! sunos ; then
+  _mlib=no
+ fi
  echocheck "Sun mediaLib"
  if test "$_mlib" = auto ; then
(copyrighted, don't use in configure;)




More information about the MPlayer-dev-eng mailing list