[MPlayer-dev-eng] [PATCH] Faad update

[Diego Biurrun]

On Fri, Mar 17, 2006 at 04:54:46PM +0100, Roberto Togni wrote:
> On Fri, 17 Mar 2006 00:23:50 +0100
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > On Thu, Mar 16, 2006 at 11:08:48PM +0100, Roberto Togni wrote:
> > > 
> > > It works for me, please review and test it.
> > 
> > When compiling with -DFIXED_POINT (see libfaad2/Makefile):
> > 
> > cc -c -I. -I../libvo -I../../libvo -I/usr/X11R6/include -g -O4 -mcpu=7450 -mtune=7450 -maltivec -mabi=altivec -pipe -ffast-math -fomit-frame-pointer -D_REENTRANT -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64  -DFIXED_POINT -o specrec.o specrec.c
> > specrec.c: In function 'reconstruct_single_channel': specrec.c:1037: error: 'struct <anonymous>' has no member named 'sbr_alloced'
> > make: *** [specrec.o] Error 1
> > 
> 
> No idea, i never compiled it with fixed point. Anybody can comment on
> this? Is it possible to compile external faad with fixed point? Does it
> work with the 20060915 snapsots or with latest cvs?

The last time I tried it worked with the external snapshot, but not
after applying our patch.  I'm not sure if this is still correct,
though, it was a long time ago.

> > I have another issue on my Mac: The following two samples fail to play
> > correctly:
> > 
> > http://www.mplayerhq.hu/MPlayer/samples/A-codecs/AAC/faad2-fail.mkv
> > http://www.mplayerhq.hu/MPlayer/samples/A-codecs/AAC/zx.eva.renewal.01.divx511.mkv
> > 
> > The following error message is printed to the console
> > 
> > FAAD: compressed input bitrate missing, assuming 128kbit/s!
> > 
> > and the audio is garbled.  It appears to be played very very slowly and
> > at a low volume, starting with some delay.  The effect is somewhat hard
> > to describe.  mplayer -v output below.
> 
> Confirmed. They works with external faad and pre7

Oh, this is not PPC-specific?

> > Also, if/when you apply this, please update the information about FAAD2
> > in the Copyright file.
> > 
> Don't worry, looks like it's not going to happen soon :(

Nah, this cannot be so hard to figure out...

Diego